-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](funcs) map struct construct funcs #39699
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38465 ms
|
TPC-DS: Total hot run time: 196642 ms
|
ClickBench: Total hot run time: 30.61 s
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38441 ms
|
TPC-DS: Total hot run time: 191859 ms
|
ClickBench: Total hot run time: 31.05 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes backport: #39699 Issue Number: close #xxx <!--Describe your changes.-->
we should not change the column which is passed from a block when we execute a function , because this block may be used in other expression or other exec node
we should not change the column which is passed from a block when we execute a function , because this block may be used in other expression or other exec node
Proposed changes
we should not change the column which is passed from a block when we execute a function , because this block may be used in other expression or other exec node
Issue Number: close #xxx